Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Make missing module suggestion instead of erro… #34193

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

kyliau commented Dec 2, 2019

…r (#34115)

If a Component or Directive is not part of any NgModule, the language
service currently produces an error message. This should not be an
error. Instead, it should be a suggestion.

This PR removes ng.DiagnosticKind, and instead reuses
ts.DiagnosticCategory.

PR closes angular/vscode-ng-language-service#458

PR Close #34115

(cherry picked from commit 7eccbcd)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

#34115)

If a Component or Directive is not part of any NgModule, the language
service currently produces an error message. This should not be an
error. Instead, it should be a suggestion.

This PR removes `ng.DiagnosticKind`, and instead reuses
`ts.DiagnosticCategory`.

PR closes angular/vscode-ng-language-service#458

PR Close #34115

(cherry picked from commit 7eccbcd)
@kyliau kyliau requested a review from angular/tools-language-service as a code owner Dec 2, 2019
@ngbot ngbot bot modified the milestone: needsTriage Dec 2, 2019
@googlebot googlebot added the cla: yes label Dec 2, 2019
mhevery added a commit that referenced this pull request Dec 3, 2019
#34115) (#34193)

If a Component or Directive is not part of any NgModule, the language
service currently produces an error message. This should not be an
error. Instead, it should be a suggestion.

This PR removes `ng.DiagnosticKind`, and instead reuses
`ts.DiagnosticCategory`.

PR closes angular/vscode-ng-language-service#458

PR Close #34115

(cherry picked from commit 7eccbcd)

PR Close #34193
@mhevery

This comment has been minimized.

Copy link
Member

mhevery commented Dec 3, 2019

merged as d2538ca

@mhevery mhevery closed this Dec 3, 2019
@kyliau kyliau deleted the kyliau:9.0.x branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.