Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply standard header case convention in docs #34196

Open
wants to merge 4 commits into
base: master
from

Conversation

@jbogarthyde
Copy link
Contributor

jbogarthyde commented Dec 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The Google doc guideline to use sentence-style capitalization for page titles is not in the Angular doc guidelines, and is not applied consistently.

Issue Number: #21605

What is the new behavior?

  • Adds the recommendation to the guidelines
  • Applies the correct case to all pages
  • Fixes some incidental terminology and organizational inconsistencies encountered while touching every page.

Does this PR introduce a breaking change?

  • Yes
  • No
@ngbot ngbot bot modified the milestone: Backlog Dec 2, 2019
@jbogarthyde

This comment has been minimized.

Copy link
Contributor Author

jbogarthyde commented Dec 2, 2019

This is a docs-only change and does not actually require technical review from every code-owner.
@kara should look at it, since it includes some terminology/doc org corrections for ivy/ngcc.

@jbogarthyde jbogarthyde added this to Committed - Selected for development in docs Dec 2, 2019
@jbogarthyde jbogarthyde moved this from Committed - Selected for development to In Review in docs Dec 2, 2019
Copy link
Contributor

kapunahelewong left a comment

Wow, thanks for this Judy. Did you mean to delete ngcc.md? Otherwise LGTM!

@jbogarthyde jbogarthyde requested a review from angular/fw-docs-marketing as a code owner Dec 2, 2019
@googlebot googlebot added the cla: yes label Dec 2, 2019
@jbogarthyde jbogarthyde force-pushed the jbogarthyde:jb-head1-style branch from a586bfc to e4a86df Dec 2, 2019
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 2, 2019

@jbogarthyde jbogarthyde requested a review from IgorMinar as a code owner Dec 3, 2019
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 3, 2019

@jbogarthyde

This comment has been minimized.

Copy link
Contributor Author

jbogarthyde commented Dec 3, 2019

Did you mean to delete ngcc.md? Otherwise LGTM!

Yes -- it was a whole new page that just had a 2-sentence definition of the term, and sat uneasily in the CLI section. I added the definition to the glossary (along with "Ivy") and replaced the references to the page with references to the glossary definition.

@jbogarthyde jbogarthyde moved this from In Review to Waiting for Approval in docs Dec 3, 2019
@jbogarthyde jbogarthyde force-pushed the jbogarthyde:jb-head1-style branch from ea0a5d8 to f232db2 Dec 4, 2019
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 4, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 4, 2019

@jbogarthyde jbogarthyde force-pushed the jbogarthyde:jb-head1-style branch from 03aa42c to 535054a Dec 9, 2019
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 9, 2019

@jbogarthyde jbogarthyde force-pushed the jbogarthyde:jb-head1-style branch from 535054a to dd9a6ae Dec 10, 2019
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 10, 2019

Copy link
Member

petebacondarwin left a comment

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
docs
Waiting for Approval
5 participants
You can’t perform that action at this time.