Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upApply standard header case convention in docs #34196
Conversation
This comment has been minimized.
This comment has been minimized.
This is a docs-only change and does not actually require technical review from every code-owner. |
Wow, thanks for this Judy. Did you mean to delete |
This comment has been minimized.
This comment has been minimized.
mary-poppins
commented
Dec 2, 2019
You can preview e4a86df at https://pr34196-e4a86df.ngbuilds.io/. |
This comment has been minimized.
This comment has been minimized.
mary-poppins
commented
Dec 3, 2019
You can preview ea0a5d8 at https://pr34196-ea0a5d8.ngbuilds.io/. |
This comment has been minimized.
This comment has been minimized.
Yes -- it was a whole new page that just had a 2-sentence definition of the term, and sat uneasily in the CLI section. I added the definition to the glossary (along with "Ivy") and replaced the references to the page with references to the glossary definition. |
This comment has been minimized.
This comment has been minimized.
mary-poppins
commented
Dec 4, 2019
You can preview f232db2 at https://pr34196-f232db2.ngbuilds.io/. |
This comment has been minimized.
This comment has been minimized.
mary-poppins
commented
Dec 4, 2019
You can preview 03aa42c at https://pr34196-03aa42c.ngbuilds.io/. |
This comment has been minimized.
This comment has been minimized.
mary-poppins
commented
Dec 9, 2019
You can preview 535054a at https://pr34196-535054a.ngbuilds.io/. |
This comment has been minimized.
This comment has been minimized.
mary-poppins
commented
Dec 10, 2019
You can preview dd9a6ae at https://pr34196-dd9a6ae.ngbuilds.io/. |
LGTM! |
jbogarthyde commentedDec 2, 2019
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The Google doc guideline to use sentence-style capitalization for page titles is not in the Angular doc guidelines, and is not applied consistently.
Issue Number: #21605
What is the new behavior?
Does this PR introduce a breaking change?