Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: guard `ngI18nClosureMode` #34211

Conversation

@petebacondarwin
Copy link
Member

petebacondarwin commented Dec 3, 2019

@petebacondarwin petebacondarwin requested review from angular/fw-compiler as code owners Dec 3, 2019
@ngbot ngbot bot modified the milestone: needsTriage Dec 3, 2019
@googlebot googlebot added the cla: yes label Dec 3, 2019
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-guard-ng-i18n-closure-mode branch from 63d5602 to 919baac Dec 3, 2019
Copy link
Member

filipesilva left a comment

LGTM aside from the one comment.

packages/core/src/application_module.ts Outdated Show resolved Hide resolved
If the `ngI18nClosureMode` global check actually makes it
through to the runtime, then checks for its existence should
be guarded to prevent `Reference undefined` errors in strict
mode.

(Normally, it is stripped out by dead code elimination during
build optimization.)
…rated code

If the `ngI18nClosureMode` global check actually makes it
through to the runtime, then checks for its existence should
be guarded to prevent `Reference undefined` errors in strict
mode.

(Normally, it is stripped out by dead code elimination during
build optimization.)

This comment ensures that generated template code guards
this global check.
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-guard-ng-i18n-closure-mode branch from 919baac to fb7afda Dec 3, 2019
@mhevery

This comment has been minimized.

Copy link
Member

mhevery commented Dec 3, 2019

@mhevery mhevery closed this in bc7cde0 Dec 4, 2019
mhevery added a commit that referenced this pull request Dec 4, 2019
…rated code (#34211)

If the `ngI18nClosureMode` global check actually makes it
through to the runtime, then checks for its existence should
be guarded to prevent `Reference undefined` errors in strict
mode.

(Normally, it is stripped out by dead code elimination during
build optimization.)

This comment ensures that generated template code guards
this global check.

PR Close #34211
mhevery added a commit that referenced this pull request Dec 4, 2019
If the `ngI18nClosureMode` global check actually makes it
through to the runtime, then checks for its existence should
be guarded to prevent `Reference undefined` errors in strict
mode.

(Normally, it is stripped out by dead code elimination during
build optimization.)

PR Close #34211
mhevery added a commit that referenced this pull request Dec 4, 2019
…rated code (#34211)

If the `ngI18nClosureMode` global check actually makes it
through to the runtime, then checks for its existence should
be guarded to prevent `Reference undefined` errors in strict
mode.

(Normally, it is stripped out by dead code elimination during
build optimization.)

This comment ensures that generated template code guards
this global check.

PR Close #34211
@petebacondarwin petebacondarwin deleted the petebacondarwin:i18n-guard-ng-i18n-closure-mode branch Dec 4, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 4, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.