Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): update closure locales to include directionality data #34240

Closed
wants to merge 1 commit into from

Conversation

@josephperrott
Copy link
Member

josephperrott commented Dec 4, 2019

When directionality data was added to @angular/common locales, only
the externally used locales were updated. We need to additionally
update the closure locales which are synced into google3.

When directionality data was added to @angular/common locales, only
the externally used locales were updated.  We need to additionally
update the closure locales which are synced into google3.
@josephperrott josephperrott requested a review from angular/fw-i18n as a code owner Dec 4, 2019
@ngbot ngbot bot added this to the needsTriage milestone Dec 4, 2019
@googlebot googlebot added the cla: yes label Dec 4, 2019
@josephperrott josephperrott requested a review from mhevery Dec 4, 2019
Copy link
Member

petebacondarwin left a comment

There are a lot of formatting changes. I hope that there is nothing bad hidden amongst them.

@mhevery mhevery closed this in f9e959e Dec 4, 2019
mhevery added a commit that referenced this pull request Dec 4, 2019
…34240)

When directionality data was added to @angular/common locales, only
the externally used locales were updated.  We need to additionally
update the closure locales which are synced into google3.

PR Close #34240
mhevery added a commit that referenced this pull request Dec 4, 2019
… data (#34240)"

This reverts commit a02bde7.
@josephperrott josephperrott deleted the josephperrott:cldr-closure branch Dec 4, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 4, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.