Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Remove getExternalFiles() #34260

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

kyliau commented Dec 5, 2019

This commit removes the getExternalFiles() from the tsserver plugin.
This API is no longer needed now that we do not intend to support
external templates under the plugin mode.
Instead, the external files are added to the project only when they are
opened by the user.
For complete discussion, see angular/vscode-ng-language-service#473

PR closes angular/vscode-ng-language-service#469
PR closes angular/vscode-ng-language-service#473

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This commit removes the `getExternalFiles()` from the tsserver plugin.
This API is no longer needed now that we do not intend to support
external templates under the plugin mode.
Instead, the external files are added to the project only when they are
opened by the user.
For complete discussion, see angular/vscode-ng-language-service#473

PR closes angular/vscode-ng-language-service#469
PR closes angular/vscode-ng-language-service#473
@kyliau kyliau requested a review from ayazhafiz Dec 5, 2019
@kyliau kyliau requested a review from angular/tools-language-service as a code owner Dec 5, 2019
@ngbot ngbot bot modified the milestone: needsTriage Dec 5, 2019
@googlebot googlebot added the cla: yes label Dec 5, 2019
AndrewKushnir added a commit that referenced this pull request Dec 5, 2019
This commit removes the `getExternalFiles()` from the tsserver plugin.
This API is no longer needed now that we do not intend to support
external templates under the plugin mode.
Instead, the external files are added to the project only when they are
opened by the user.
For complete discussion, see angular/vscode-ng-language-service#473

PR closes angular/vscode-ng-language-service#469
PR closes angular/vscode-ng-language-service#473

PR Close #34260
@kyliau kyliau deleted the kyliau:external-files branch Dec 6, 2019
josephperrott added a commit to josephperrott/angular that referenced this pull request Dec 11, 2019
This commit removes the `getExternalFiles()` from the tsserver plugin.
This API is no longer needed now that we do not intend to support
external templates under the plugin mode.
Instead, the external files are added to the project only when they are
opened by the user.
For complete discussion, see angular/vscode-ng-language-service#473

PR closes angular/vscode-ng-language-service#469
PR closes angular/vscode-ng-language-service#473

PR Close angular#34260
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 6, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.