Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): ensure localized strings are ES5 compatible for JIT mode #34265

Closed

Conversation

@petebacondarwin
Copy link
Member

petebacondarwin commented Dec 6, 2019

Previously the JIT evaluated code for ivy localized strings included
backtick tagged template strings, which are not compatible with ES5
in legacy browsers such as IE 11.

Now the generated code is ES5 compatible.

Fixes #34246

@petebacondarwin petebacondarwin requested a review from angular/fw-compiler as a code owner Dec 6, 2019
@ngbot ngbot bot added this to the needsTriage milestone Dec 6, 2019
@googlebot googlebot added the cla: yes label Dec 6, 2019
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-jit-compiler branch from 627748e to 394bfe4 Dec 6, 2019
@gkalpak gkalpak mentioned this pull request Dec 6, 2019
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-jit-compiler branch from 394bfe4 to fb69175 Dec 6, 2019
@petebacondarwin petebacondarwin requested a review from alxhub Dec 6, 2019
Previously the JIT evaluated code for ivy localized strings included
backtick tagged template strings, which are not compatible with ES5
in legacy browsers such as IE 11.

Now the generated code is ES5 compatible.

Fixes #34246
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:i18n-jit-compiler branch from fb69175 to 94f2016 Dec 6, 2019
@alxhub
alxhub approved these changes Dec 6, 2019
@alxhub

This comment has been minimized.

Copy link
Contributor

alxhub commented Dec 6, 2019

AndrewKushnir added a commit that referenced this pull request Dec 6, 2019
…de (#34265)

Previously the JIT evaluated code for ivy localized strings included
backtick tagged template strings, which are not compatible with ES5
in legacy browsers such as IE 11.

Now the generated code is ES5 compatible.

Fixes #34246

PR Close #34265
@petebacondarwin petebacondarwin deleted the petebacondarwin:i18n-jit-compiler branch Dec 7, 2019
josephperrott added a commit to josephperrott/angular that referenced this pull request Dec 11, 2019
…de (angular#34265)

Previously the JIT evaluated code for ivy localized strings included
backtick tagged template strings, which are not compatible with ES5
in legacy browsers such as IE 11.

Now the generated code is ES5 compatible.

Fixes angular#34246

PR Close angular#34265
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 7, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.