fix(docs-infra): convert hard-coded comparing-observables examples into a proper mini-app
#34327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
aio: preview
area: build & ci
|
You can preview dc19af6 at https://pr34327-dc19af6.ngbuilds.io/. |
gkalpak
requested changes
Dec 12, 2019
aio/content/examples/comparing-observables/e2e/src/app.e2e-spec.ts
Outdated
Show resolved
Hide resolved
aio/content/examples/comparing-observables/src/observables-error.ts
Outdated
Show resolved
Hide resolved
aio/content/examples/comparing-observables/src/promise-error.ts
Outdated
Show resolved
Hide resolved
aio/content/examples/comparing-observables/src/promise-error.ts
Outdated
Show resolved
Hide resolved
gkalpak
added
state: WIP
and removed
action: review
|
You can preview 9def4e8 at https://pr34327-9def4e8.ngbuilds.io/. |
gkalpak
requested changes
Dec 13, 2019
|
You can preview dd1e075 at https://pr34327-dd1e075.ngbuilds.io/. |
gkalpak
requested changes
Dec 15, 2019
There was a problem hiding this comment.
Almost there 🎉
Can you please take care of #34327 (comment) (rename the files to plural and the docregion to singular), squash the commits into one and update the commit message to something along the lines of dd9793f?
sonukapoor
force-pushed
the
converts-hard-coded-examples-to-proper-examples
branch
from
dd1e075
to
5763d55
Compare
|
@gkalpak I believe this resolves everything. LMK if anything is missing. |
|
You can preview 5763d55 at https://pr34327-5763d55.ngbuilds.io/. |
sonukapoor
force-pushed
the
converts-hard-coded-examples-to-proper-examples
branch
from
5763d55
to
b7ebe78
Compare
gkalpak
changed the title
comparing-observables examples into a proper mini-app
sonukapoor
force-pushed
the
converts-hard-coded-examples-to-proper-examples
branch
from
b7ebe78
to
70e85d1
Compare
gkalpak
added
action: review
gkalpak
approved these changes
Dec 16, 2019
sonukapoor
force-pushed
the
converts-hard-coded-examples-to-proper-examples
branch
from
70e85d1
to
24a7a71
Compare
…into a proper mini-app Previously, the examples in the `comparing-observables` guide were hard-coded. This made it impossible to test them and verify they are correct. This commit fixes this by converting them into a proper mini-app. In a subsequent commit, tests will be added to verify that the source code works as expected (and guard against regressions). Fixes angular#31024
sonukapoor
force-pushed
the
converts-hard-coded-examples-to-proper-examples
branch
from
24a7a71
to
692bf9e
Compare
gkalpak
added
action: merge
|
You can preview 692bf9e at https://pr34327-692bf9e.ngbuilds.io/. |
kara
added
the
action: review
14 tasks
|
@IgorMinar Can you please review this? |
IgorMinar
approved these changes
Jan 19, 2020
IgorMinar
added
action: merge
gkalpak
added
the
merge: caretaker note
|
@caretaker: Global approval for the docs-only changes. |
matsko
pushed a commit
that referenced
this pull request
Jan 21, 2020
…into a proper mini-app (#34327) Previously, the examples in the `comparing-observables` guide were hard-coded. This made it impossible to test them and verify they are correct. This commit fixes this by converting them into a proper mini-app. In a subsequent commit, tests will be added to verify that the source code works as expected (and guard against regressions). Fixes #31024 PR Close #34327
sonukapoor
deleted the
converts-hard-coded-examples-to-proper-examples
branch
sonukapoor
added a commit
to sonukapoor/angular
that referenced
this pull request
Feb 13, 2020
…into a proper mini-app (angular#34327) Previously, the examples in the `comparing-observables` guide were hard-coded. This made it impossible to test them and verify they are correct. This commit fixes this by converting them into a proper mini-app. In a subsequent commit, tests will be added to verify that the source code works as expected (and guard against regressions). Fixes angular#31024 PR Close angular#34327
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…stable files
It also updates some indention issues with the code that is part of inline tables.
Fixes #31024
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #31024
What is the new behavior?
Does this PR introduce a breaking change?
Other information