New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs-infra): convert hard-coded comparing-observables
examples into a proper mini-app
#34327
fix(docs-infra): convert hard-coded comparing-observables
examples into a proper mini-app
#34327
Conversation
You can preview dc19af6 at https://pr34327-dc19af6.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off to a great start 🎉
Some more fine-tuning and this should be good to go!
(BTW, why the empty main.ts
file?)
aio/content/examples/comparing-observables/e2e/src/app.e2e-spec.ts
Outdated
Show resolved
Hide resolved
aio/content/examples/comparing-observables/src/observables-error.ts
Outdated
Show resolved
Hide resolved
aio/content/examples/comparing-observables/src/promise-error.ts
Outdated
Show resolved
Hide resolved
aio/content/examples/comparing-observables/src/promise-error.ts
Outdated
Show resolved
Hide resolved
You can preview 9def4e8 at https://pr34327-9def4e8.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shaping up nicely ✨
I left a few more comments (nothing major).
You can preview dd1e075 at https://pr34327-dd1e075.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there 🎉
Can you please take care of #34327 (comment) (rename the files to plural and the docregion to singular), squash the commits into one and update the commit message to something along the lines of dd9793f?
dd1e075
to
5763d55
Compare
@gkalpak I believe this resolves everything. LMK if anything is missing. |
You can preview 5763d55 at https://pr34327-5763d55.ngbuilds.io/. |
5763d55
to
b7ebe78
Compare
comparing-observables
examples into a proper mini-app
b7ebe78
to
70e85d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @sonukapoor! Thx 💯
70e85d1
to
24a7a71
Compare
…into a proper mini-app Previously, the examples in the `comparing-observables` guide were hard-coded. This made it impossible to test them and verify they are correct. This commit fixes this by converting them into a proper mini-app. In a subsequent commit, tests will be added to verify that the source code works as expected (and guard against regressions). Fixes angular#31024
24a7a71
to
692bf9e
Compare
You can preview 692bf9e at https://pr34327-692bf9e.ngbuilds.io/. |
@IgorMinar Can you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you
@caretaker: Global approval for the docs-only changes. |
…into a proper mini-app (#34327) Previously, the examples in the `comparing-observables` guide were hard-coded. This made it impossible to test them and verify they are correct. This commit fixes this by converting them into a proper mini-app. In a subsequent commit, tests will be added to verify that the source code works as expected (and guard against regressions). Fixes #31024 PR Close #34327
…into a proper mini-app (angular#34327) Previously, the examples in the `comparing-observables` guide were hard-coded. This made it impossible to test them and verify they are correct. This commit fixes this by converting them into a proper mini-app. In a subsequent commit, tests will be added to verify that the source code works as expected (and guard against regressions). Fixes angular#31024 PR Close angular#34327
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…stable files
It also updates some indention issues with the code that is part of inline tables.
Fixes #31024
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #31024
What is the new behavior?
Does this PR introduce a breaking change?
Other information