Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): i18n - remove `translate` function when clearing translations #34346

Conversation

@petebacondarwin
Copy link
Member

petebacondarwin commented Dec 11, 2019

The loadTranslations() function will attach the translate() function
to $localize.translate to cause runtime translation to occur.

We should cleanup after ourselves by unattaching this function when
we call clearTranslations().

Fixes #32781

The `loadTranslations()` function will attach the `translate()` function
to `$localize.translate` to cause runtime translation to occur.

We should cleanup after ourselves by unattaching this function when
we call `clearTranslations()`.

Fixes #32781
Copy link
Contributor

AndrewKushnir left a comment

LGTM 👍

@kara kara closed this in 6ce9403 Dec 11, 2019
kara added a commit that referenced this pull request Dec 11, 2019
…ns (#34346)

The `loadTranslations()` function will attach the `translate()` function
to `$localize.translate` to cause runtime translation to occur.

We should cleanup after ourselves by unattaching this function when
we call `clearTranslations()`.

Fixes #32781

PR Close #34346
@petebacondarwin petebacondarwin deleted the petebacondarwin:i18n-cleanup-test-output branch Dec 12, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 12, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.