Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): improve ExpressionChangedAfterChecked error #34381

Closed
wants to merge 6 commits into from

Conversation

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Dec 12, 2019

Prior to this change, the ExpressionChangedAfterChecked error thrown in Ivy was missing useful information that was available in View Engine, specifically: missing property name for property bindings and also the content of the entire property interpolation (only a changed value was displayed) if one of expressions was changed unexpectedly. This commit improves the error message by including the mentioned information into the error text.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No
@ngbot ngbot bot modified the milestone: needsTriage Dec 12, 2019
@googlebot googlebot added the cla: yes label Dec 12, 2019
@AndrewKushnir AndrewKushnir marked this pull request as ready for review Dec 12, 2019
@AndrewKushnir AndrewKushnir requested a review from angular/fw-core as a code owner Dec 12, 2019
Copy link
Contributor

kara left a comment

Thanks for picking this up!

packages/core/src/render3/errors.ts Outdated Show resolved Hide resolved
packages/core/src/render3/errors.ts Outdated Show resolved Hide resolved
packages/core/src/render3/errors.ts Show resolved Hide resolved
packages/core/src/render3/errors.ts Outdated Show resolved Hide resolved
@AndrewKushnir AndrewKushnir force-pushed the AndrewKushnir:FW-1283_cd_errors branch from fe283e4 to cda4bd1 Dec 17, 2019
@AndrewKushnir AndrewKushnir requested a review from kara Dec 17, 2019
@AndrewKushnir

This comment has been minimized.

Copy link
Contributor Author

AndrewKushnir commented Dec 17, 2019

@kara thanks for the review! I've addressed your comments, could you please have another look?

packages/core/src/render3/errors.ts Outdated Show resolved Hide resolved
packages/core/src/render3/errors.ts Outdated Show resolved Hide resolved
@kara
kara approved these changes Dec 17, 2019
Copy link
Contributor

kara left a comment

LGTM, with a few more small things

Prior to this change, the ExpressionChangedAfterChecked error thrown in Ivy was missing useful information that was available in View Engine, specifically: missing property name for proprty bindings and also the content of the entire property interpolation (only a changed value was displayed) if one of expressions was changed unexpectedly. This commit improves the error message by including the mentioned information into the error text.
@AndrewKushnir AndrewKushnir force-pushed the AndrewKushnir:FW-1283_cd_errors branch from 5d51454 to c9003e4 Dec 18, 2019
@AndrewKushnir

This comment has been minimized.

Copy link
Contributor Author

AndrewKushnir commented Dec 18, 2019

@kara
kara approved these changes Dec 18, 2019
Copy link
Contributor

kara left a comment

LGTM

@kara kara removed their assignment Dec 18, 2019
@kara kara closed this in 9d1175e Dec 18, 2019
kara added a commit that referenced this pull request Dec 18, 2019
Prior to this change, the ExpressionChangedAfterChecked error thrown in Ivy was missing useful information that was available in View Engine, specifically: missing property name for proprty bindings and also the content of the entire property interpolation (only a changed value was displayed) if one of expressions was changed unexpectedly. This commit improves the error message by including the mentioned information into the error text.

PR Close #34381
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 18, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.