Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): correctly associate output bound events with directives #34479

Closed
wants to merge 3 commits into from

Conversation

@ayazhafiz
Copy link
Member

ayazhafiz commented Dec 18, 2019

Duplicate of #31938 targeting Version 9


Previously, bound events were incorrectly bound to directives with
inputs matching the bound event attribute. This fixes that so bound
events can only be bound to directives with matching outputs.

Adds tests for all kinds of directive matching on bound attributes.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

ayazhafiz added 3 commits Jul 31, 2019
Previously, bound events were incorrectly bound to directives with
inputs matching the bound event attribute. This fixes that so bound
events can only be bound to directives with matching outputs.

Adds tests for all kinds of directive matching on bound attributes.
@ayazhafiz ayazhafiz requested review from JoostK and kara Dec 18, 2019
@ayazhafiz ayazhafiz requested a review from angular/fw-compiler as a code owner Dec 18, 2019
@ngbot ngbot bot added this to the needsTriage milestone Dec 18, 2019
@googlebot googlebot added the cla: yes label Dec 18, 2019
@kara

This comment has been minimized.

Copy link
Contributor

kara commented Dec 18, 2019

caretaker note: this was already approved for another branch

alxhub added a commit that referenced this pull request Dec 19, 2019
…4479)

Previously, bound events were incorrectly bound to directives with
inputs matching the bound event attribute. This fixes that so bound
events can only be bound to directives with matching outputs.

Adds tests for all kinds of directive matching on bound attributes.

PR Close #34479
@alxhub

This comment has been minimized.

Copy link
Contributor

alxhub commented Dec 19, 2019

Merged as fde5067

@alxhub alxhub closed this Dec 19, 2019
@ayazhafiz ayazhafiz deleted the ayazhafiz:fix/io-binding-9.0.x-patch branch Dec 19, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 19, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.