Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): The pipe method should not include parentheses #34485

Closed

Conversation

@ivanwonder
Copy link
Contributor

ivanwonder commented Dec 19, 2019

The pipe method should not include parentheses.
e.g. {{ value_expression | slice : start [ : end ] }}.
https://angular.io/api/common/SlicePipe

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ivanwonder ivanwonder requested a review from angular/tools-language-service as a code owner Dec 19, 2019
@googlebot googlebot added the cla: yes label Dec 19, 2019
@ngbot ngbot bot modified the milestone: needsTriage Dec 19, 2019
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
@ivanwonder ivanwonder force-pushed the ivanwonder:pipe-method-completion-bug branch from f00983b to 0d39a40 Dec 19, 2019
@ivanwonder ivanwonder force-pushed the ivanwonder:pipe-method-completion-bug branch from 0d39a40 to 2af56bc Dec 19, 2019
@ayazhafiz ayazhafiz requested a review from kyliau Dec 19, 2019
@kyliau
kyliau approved these changes Dec 19, 2019
Copy link
Member

kyliau left a comment

thank you for fixing this!

@alxhub alxhub closed this in ba2fd31 Jan 6, 2020
alxhub added a commit that referenced this pull request Jan 6, 2020
@ivanwonder ivanwonder deleted the ivanwonder:pipe-method-completion-bug branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.