Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language-service): Show documentation on hover #34506

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

kyliau commented Dec 20, 2019

This commit adds dpcumentation to the hover tooltip.

Hover over property:
Screen Shot 2019-12-19 at 6 28 44 PM

Hover over selector:
Screen Shot 2019-12-19 at 6 28 52 PM

PR closes angular/vscode-ng-language-service#321

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from ayazhafiz Dec 20, 2019
@kyliau kyliau requested a review from angular/tools-language-service as a code owner Dec 20, 2019
@googlebot googlebot added the cla: yes label Dec 20, 2019
@ngbot ngbot bot added this to the needsTriage milestone Dec 20, 2019
@@ -8,11 +8,14 @@

import {CompileSummaryKind, StaticSymbol} from '@angular/compiler';
import * as ts from 'typescript';

This comment has been minimized.

Copy link
@kyliau

kyliau Dec 20, 2019

Author Member

These empty lines are automatically added by the formatter 🤷🏻‍♂️

@kyliau kyliau force-pushed the kyliau:docs branch from 8281468 to 93a1490 Dec 20, 2019
@kyliau kyliau force-pushed the kyliau:docs branch from a121a47 to 1a05796 Dec 20, 2019
@ayazhafiz

This comment has been minimized.

Copy link
Member

ayazhafiz commented Dec 21, 2019

@kyliau merge conflicts ):

This commit adds dpcumentation to the hover tooltip.

PR closes angular/vscode-ng-language-service#321
@kyliau kyliau force-pushed the kyliau:docs branch from 1a05796 to d875267 Dec 21, 2019
@xiaoxiangmoe

This comment has been minimized.

Copy link

xiaoxiangmoe commented Jan 2, 2020

@kyliau This feature is amazing! 🎉
Any progress on this pr?

@alxhub alxhub closed this in c079f38 Jan 6, 2020
alxhub added a commit that referenced this pull request Jan 6, 2020
This commit adds dpcumentation to the hover tooltip.

PR closes angular/vscode-ng-language-service#321

PR Close #34506
@kyliau kyliau deleted the kyliau:docs branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.