Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): delete obsolete NgClassBase and NgStyleBase #34745

Closed
wants to merge 1 commit into from

Conversation

@IgorMinar
Copy link
Member

IgorMinar commented Jan 12, 2020

These classes are no longer needed.

These classes were accidently exported as public api in the past, but fortunately since they are
useless, we don't expect anyone to depend on them, so I'm simply deleting them.

@IgorMinar IgorMinar requested review from angular/fw-core as code owners Jan 12, 2020
@googlebot googlebot added the cla: yes label Jan 12, 2020
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 12, 2020

These classes are no longer needed.

These classes were accidently exported as public api in the past, but fortunately since they are
useless, we don't expect anyone to depend on them, so I'm simply deleting them.
@IgorMinar IgorMinar force-pushed the IgorMinar:fix/remove-NgClassBase branch from 241ea03 to e345537 Jan 12, 2020
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 12, 2020

@ngbot ngbot bot added this to the needsTriage milestone Jan 14, 2020
@IgorMinar

This comment has been minimized.

Copy link
Member Author

IgorMinar commented Jan 16, 2020

this PR is obsolete and will be resolved by @mhevery's PRs on the styling branch.

@IgorMinar IgorMinar closed this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.