Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules nodejs 1.0.0 windows ci #34750

Closed

Conversation

@gregmagolan
Copy link
Contributor

gregmagolan commented Jan 12, 2020

Windows CI for #34736

@googlebot googlebot added the cla: yes label Jan 12, 2020
@gregmagolan gregmagolan force-pushed the gregmagolan:rules_nodejs_1.0.0_windows_ci branch 2 times, most recently from d22d319 to 8b30501 Jan 12, 2020
@gregmagolan gregmagolan force-pushed the gregmagolan:rules_nodejs_1.0.0_windows_ci branch 4 times, most recently from ad55e3c to 3a8fe25 Jan 13, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jan 14, 2020
gregmagolan added 4 commits Dec 29, 2019
Brings in the fix for stamping which was preventing many targets from getting cached.
The major one that affects the angular repo is the removal of the bootstrap attribute in nodejs_binary, nodejs_test and jasmine_node_test in favor of using templated_args --node_options=--require=/path/to/script. The side-effect of this is that the bootstrap script does not get the require.resolve patches with explicitly loading the targets _loader.js file.
bazel query now using: kind("ng_package|pkg_npm", //packages/...)
@gregmagolan gregmagolan force-pushed the gregmagolan:rules_nodejs_1.0.0_windows_ci branch from 3a8fe25 to 6012365 Jan 15, 2020
gregmagolan added 15 commits Nov 27, 2019
…nodejs 1.0.0

For the purposes of the integration test the zone.js script & bundle script tags can just go into the source index.html itself. The purpose of the integration test is is to test @angular/bazel & ng_module & ng_package so there is no need to exercise html_insert_assets in integration/bazel.
This brings in a required fix to allow for 0.0.0 dev version of @angular/core for integration testing. Without this the following error is now observed:

```
This version of CLI is only compatible with Angular versions ^9.0.0-beta || >=9.0.0 <10.0.0,
but Angular version 0.0.0 was found instead.
```

NB: rc.7 breaks the cli-hello-world-ivy-i18n integration test
This brings in a few minor fixes including a better way to patch require for bootstrap scripts

Also remove install_source_map_support attribute from nodejs_binary targets This attribute will be removed from nodejs_binary in the future
This removes the churn in the existing bootstrap scripts.
This is recommended in the Bazel docs as $(location) is ambiguous and can mean either $(execpath) or $(rootpath) depending on the context.
Adds tests to verify that jasmine_node_test targets fail as expected.
This is to catch any future regressions to jasmine_node_test where tests pass silently without executing.
See bazelbuild/rules_nodejs#1540 for an example of a potential regression.
This release resolves the bootstrap require patching issue with jasmine_node_test. Require patches are now included before any bootstrap scripts.
Fix build error after rebasing to HEAD
@gregmagolan gregmagolan force-pushed the gregmagolan:rules_nodejs_1.0.0_windows_ci branch from 6012365 to 7bc2c1d Jan 15, 2020
@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

gregmagolan commented Jan 15, 2020

#34736 landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.