Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(docs-infra): change navigation in resources page #34756
https://angular.io/resources needs to be structured to be able to navigate to all resources with improved user experience. A lone scroll bar in this page will not help the reader a great deal in exploring the resources
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Earlier there was no navigation available on the resources page
Issue Number: 33526
What is the new behavior?
Added navigation to the resources page
Does this PR introduce a breaking change?
Thx, @ajitsinghkaler! This looks great. A couple more tweaks and should be ready to merge (as far as I am concerned).
I think it now also makes sense to center the content under the tabs (because it looks weird to have the tabs centered and the content below left-aligned:
Note to self:
I have left some comments to do some clean-up (which is not directly related to this PR, but would be awesome if you could do (on a separate commit)).
Other than that, this lgtm (pending the addition of tests)