Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove underscore suffix from locally scoped class ex… #34757

Closed

Conversation

@mikebolt
Copy link
Contributor

mikebolt commented Jan 13, 2020

…pression names

remove unnecessary underscore suffix and the corresponding TODO comments,
because the rollup bug was fixed: github.com/rollup/rollup/issues/2047

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
…pression names

remove unnecessary underscore suffix and the corresponding TODO comments,
because the rollup bug was fixed: github.com/rollup/rollup/issues/2047
@mikebolt mikebolt requested a review from angular/fw-core as a code owner Jan 13, 2020
@googlebot googlebot added the cla: yes label Jan 13, 2020
@mikebolt

This comment has been minimized.

Copy link
Contributor Author

mikebolt commented Jan 14, 2020

side note: there are other places where class names end in underscores. I looked through each one and they all seemed to be necessary in order to avoid collision. So, only these three class names with TODO comments were changed.

@atscott atscott added the comp: core label Jan 14, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jan 14, 2020
Copy link
Member

IgorMinar left a comment

looks great! thank you!

@IgorMinar

This comment has been minimized.

Copy link
Member

IgorMinar commented Jan 16, 2020

merge-assistance: global approval

@matsko matsko closed this in f2df1c7 Jan 16, 2020
matsko added a commit that referenced this pull request Jan 16, 2020
…pression names (#34757)

remove unnecessary underscore suffix and the corresponding TODO comments,
because the rollup bug was fixed: github.com/rollup/rollup/issues/2047

PR Close #34757
matsko added a commit to matsko/angular that referenced this pull request Jan 17, 2020
matsko added a commit to matsko/angular that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.