Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(common): update ngForTrackBy error URL #34761

Open

Conversation

@LayZeeDK
Copy link
Contributor

LayZeeDK commented Jan 13, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Error message refers to URL that is redirected to https://angular.io/api/common/NgForOf#!#change-propagation

Issue Number: N/A

What is the new behavior?

Error message refers to https://angular.io/api/common/NgForOf#change-propagation

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@LayZeeDK LayZeeDK requested a review from angular/fw-core as a code owner Jan 13, 2020
@googlebot googlebot added the cla: yes label Jan 13, 2020
@ngbot ngbot bot modified the milestone: Backlog Jan 14, 2020
@kapunahelewong kapunahelewong added this to In Review in docs Jan 14, 2020
@kapunahelewong kapunahelewong requested a review from jbogarthyde Jan 14, 2020
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Jan 14, 2020

@jbogarthyde

This comment has been minimized.

Copy link
Contributor

jbogarthyde commented Jan 14, 2020

The new URL is correct, so from a doc POV it's fine.
This is actually a code change, rather than a doc change (the error message itself is part of the definition and does not appear in the doc). So this needs code-owner approval as well as doc approval.

Copy link
Contributor

jbogarthyde left a comment

Doc URL is correct - thanks!

@LayZeeDK

This comment has been minimized.

Copy link
Contributor Author

LayZeeDK commented Jan 14, 2020

This is actually a code change, rather than a doc change (the error message itself is part of the definition and does not appear in the doc)

Thanks I was in doubt, seeing that the error message is a kind of documentation and points to the angular.io documentation.

Speaking of: What is covered by documentation content changes? The angular.io documentation and inline JSDoc-like doc blocks?

@LayZeeDK

This comment has been minimized.

Copy link
Contributor Author

LayZeeDK commented Jan 15, 2020

It would probably be better to create a g.co short URL in case the documentation URL changes again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
docs
In Review
5 participants
You can’t perform that action at this time.