Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): use console service #34763

Open

Conversation

@LayZeeDK
Copy link
Contributor

LayZeeDK commented Jan 13, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

NgForOf doesn't use the Console service and doesn't verify warnings in tests.

Issue Number: N/A

What is the new behavior?

NgForOf uses the Console service and verifies warnings in tests.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@LayZeeDK LayZeeDK requested a review from angular/fw-core as a code owner Jan 13, 2020
@googlebot googlebot added the cla: yes label Jan 13, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.