Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(language-service): Construct proper template AST from HTML ast #34764

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

kyliau commented Jan 13, 2020

The Template AST that corresponds to a given HTML AST is not always
complete, and often has to be reconstructed. This commit refactors the
code to make it easier to adapt to multiple cases.

This is a follow up to #34743

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from ayazhafiz Jan 13, 2020
@kyliau kyliau requested a review from angular/tools-language-service as a code owner Jan 13, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jan 13, 2020
@googlebot googlebot added the cla: yes label Jan 13, 2020
@kyliau

This comment has been minimized.

Copy link
Member Author

kyliau commented Jan 13, 2020

@ivanwonder Do you mind taking a look at this, please?

@kyliau kyliau force-pushed the kyliau:refactor-attr-value-compl branch 2 times, most recently from 14ab143 to 5a627d3 Jan 13, 2020
@kyliau kyliau force-pushed the kyliau:refactor-attr-value-compl branch 2 times, most recently from d83dea0 to 61f51a2 Jan 14, 2020
@ayazhafiz

This comment has been minimized.

Copy link
Member

ayazhafiz commented Jan 14, 2020

@kyliau linter ):

The Template AST that corresponds to a given HTML AST is not always
complete, and often has to be reconstructed. This commit refactors the
code to make it easier to adapt to multiple cases.
@kyliau kyliau force-pushed the kyliau:refactor-attr-value-compl branch from 61f51a2 to 87570fd Jan 14, 2020
atscott added a commit that referenced this pull request Jan 14, 2020
…st (#34764)

The Template AST that corresponds to a given HTML AST is not always
complete, and often has to be reconstructed. This commit refactors the
code to make it easier to adapt to multiple cases.

PR Close #34764
@atscott atscott closed this in 84c659e Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.