Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add a sauce-service.sh script that manages the sauce-connect as a service #34765

Closed
wants to merge 1 commit into from

Conversation

@gregmagolan
Copy link
Contributor

gregmagolan commented Jan 13, 2020

The following scripts now use the new ./scripts/saucelabs/sauce-service.sh script:

./scripts/saucelabs/start-tunnel.sh
./scripts/saucelabs/stop-tunnel.sh
./scripts/saucelabs/wait-for-tunnel.sh
./scripts/saucelabs/start-and-wait-for-tunnel.sh
./scripts/saucelabs/start-tunnel.sh no longer needs to be called as a background process as it starts up the service & returns.

This is a pre-factor for #34769

@googlebot googlebot added the cla: yes label Jan 13, 2020
@gregmagolan gregmagolan force-pushed the gregmagolan:sauce-service branch from d699c6a to 5fcd965 Jan 13, 2020
@gregmagolan gregmagolan changed the title Sauce service refactor: add a sauce-service.sh script that manages the sauce-connect as a service Jan 13, 2020
@gregmagolan gregmagolan force-pushed the gregmagolan:sauce-service branch 4 times, most recently from 42d8f59 to 6c67e3e Jan 13, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jan 14, 2020
@gregmagolan gregmagolan force-pushed the gregmagolan:sauce-service branch 10 times, most recently from f2ca9e0 to eaa248a Jan 14, 2020
@gregmagolan gregmagolan marked this pull request as ready for review Jan 14, 2020
@gregmagolan gregmagolan requested a review from angular/dev-infra-framework as a code owner Jan 14, 2020
@gregmagolan gregmagolan force-pushed the gregmagolan:sauce-service branch from eaa248a to d6a10f7 Jan 14, 2020
@gregmagolan gregmagolan force-pushed the gregmagolan:sauce-service branch 4 times, most recently from a24525b to ec35615 Jan 14, 2020
@gregmagolan gregmagolan force-pushed the gregmagolan:sauce-service branch 2 times, most recently from e5d0cea to 540a5c1 Jan 14, 2020
scripts/saucelabs/sauce-service.sh Show resolved Hide resolved
scripts/saucelabs/sauce-service.sh Show resolved Hide resolved
scripts/saucelabs/sauce-service.sh Show resolved Hide resolved
scripts/saucelabs/sauce-service.sh Show resolved Hide resolved
scripts/saucelabs/sauce-service.sh Show resolved Hide resolved
scripts/saucelabs/sauce-service.sh Show resolved Hide resolved
scripts/saucelabs/sauce-service.sh Show resolved Hide resolved
scripts/saucelabs/sauce-service.sh Show resolved Hide resolved
…t as a service

The following scripts now use the new ./scripts/saucelabs/sauce-service.sh script:
- ./scripts/saucelabs/start-tunnel.sh
- ./scripts/saucelabs/stop-tunnel.sh
- ./scripts/saucelabs/wait-for-tunnel.sh

./scripts/saucelabs/start-tunnel.sh no longer needs to be called as a background process as it starts up the service & returns.

This is a pre-factor for having Bazel pre-test call ./scripts/saucelabs/start-tunnel.sh.
@gregmagolan gregmagolan force-pushed the gregmagolan:sauce-service branch from 540a5c1 to 971e443 Jan 20, 2020
@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

gregmagolan commented Jan 22, 2020

Closing this as its included in #34769 which is a small PR anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.