Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Doguhan Uluca to GDE resources #34770

Closed

Conversation

@duluca
Copy link

duluca commented Jan 14, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Created per @StephenFluin instructions.

@duluca duluca requested a review from angular/fw-docs-marketing as a code owner Jan 14, 2020
@googlebot googlebot added the cla: yes label Jan 14, 2020
@ngbot ngbot bot modified the milestone: Backlog Jan 14, 2020
@kapunahelewong kapunahelewong added this to In Review in docs Jan 14, 2020
Copy link
Contributor

kapunahelewong left a comment

LGTM. Thanks, @duluca! Just two little things:

  1. Could you rebase so the conflicts are sorted out? If you need help with this, just tag me.
  2. After that, we'll just need marketing approval so we can move forward.

Thank you!

@duluca duluca force-pushed the duluca:docs/contributors-gde-doguhanuluca branch from 473d2b9 to ae2ac9f Jan 14, 2020
@duluca

This comment has been minimized.

Copy link
Author

duluca commented Jan 14, 2020

@kapunahelewong done. Thanks

@kapunahelewong

This comment has been minimized.

Copy link
Contributor

kapunahelewong commented Jan 15, 2020

Thank you, for rebasing @duluca, but can you squash too so that it's just one commit? Looks like you have a handle on it, but if you need help I'm happy to help. :)

@duluca duluca requested review from angular/dev-infra-framework as code owners Jan 15, 2020
@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 15, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: yes label Jan 15, 2020
@googlebot googlebot added the cla: no label Jan 15, 2020
@duluca duluca force-pushed the duluca:docs/contributors-gde-doguhanuluca branch from c597747 to ae2ac9f Jan 15, 2020
@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 15, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jan 15, 2020
@duluca duluca closed this Jan 15, 2020
@duluca duluca force-pushed the duluca:docs/contributors-gde-doguhanuluca branch from ae2ac9f to ec147bd Jan 15, 2020
@jbogarthyde jbogarthyde moved this from In Review to Done in docs Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
docs
Done
3 participants
You can’t perform that action at this time.