Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): Propagate value span of ExpressionBinding to ParsedProperty #36133

Closed
wants to merge 1 commit into from
Closed

feat(compiler): Propagate value span of ExpressionBinding to ParsedProperty #36133

wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Mar 18, 2020

…operty

This commit propagates the correct value span in an ExpressionBinding of
a microsyntax expression to ParsedProperty, which in turn porpagates the
span to the template ASTs (both VE and Ivy).

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added target: major This PR is targeted for the next major release area: compiler Issues related to `ngc`, Angular's template compiler labels Mar 18, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 18, 2020
AndrewKushnir
AndrewKushnir approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ayazhafiz ayazhafiz changed the title feat(compiler): Propagate value span of ExpressionBinding to ParsedPr… feat(compiler): Propagate value span of ExpressionBinding to ParsedProperty Mar 18, 2020
@ayazhafiz ayazhafiz added the action: presubmit The PR is in need of a google3 presubmit label Mar 18, 2020
@kyliau
Copy link
Contributor Author

kyliau commented Mar 18, 2020

presubmit: http://test/OCL:301693264:BASE:301693292:1584574165209:ab73d833

@kyliau
feat(compiler): Propagate value span of ExpressionBinding to ParsedPr…
a6e3295 
…operty

This commit propagates the correct value span in an ExpressionBinding of
a microsyntax expression to ParsedProperty, which in turn porpagates the
span to the template ASTs (both VE and Ivy).
@kyliau kyliau added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 19, 2020
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 19, 2020
@AndrewKushnir
Copy link
Contributor

@kyliau could you please check if this PR should be re-labeled to "master & patch", given that we've just released 9.1.0-rc.0 and created a new patch branch (9.1.x)? I'm adding "cleanup" label for now. Thank you.

@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: major This PR is targeted for the next major release labels Mar 19, 2020
@mhevery mhevery closed this in d714b95 Mar 20, 2020
mhevery pushed a commit that referenced this pull request Mar 20, 2020
@kyliau @mhevery
feat(compiler): Propagate value span of ExpressionBinding to ParsedPr…
2ce5fa3 
…operty (#36133)

This commit propagates the correct value span in an ExpressionBinding of
a microsyntax expression to ParsedProperty, which in turn porpagates the
span to the template ASTs (both VE and Ivy).

PR Close #36133
kyliau added a commit to kyliau/angular that referenced this pull request Mar 20, 2020
@kyliau
test(compiler): remove whitespace in spans
8d11316 
angular#36133 and angular#35986
caused a conflict in test after they both got merged to master.
This PR fixes the failed tests.
@kyliau kyliau mentioned this pull request Mar 20, 2020
Closed
14 tasks
mhevery pushed a commit that referenced this pull request Mar 20, 2020
@kyliau @mhevery
test(compiler): remove whitespace in spans (#36169)
ae3eaf8 
#36133 and #35986
caused a conflict in test after they both got merged to master.
This PR fixes the failed tests.

PR Close #36169
mhevery pushed a commit that referenced this pull request Mar 20, 2020
@kyliau @mhevery
test(compiler): remove whitespace in spans (#36169)
05eeb7d 
#36133 and #35986
caused a conflict in test after they both got merged to master.
This PR fixes the failed tests.

PR Close #36169
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 20, 2020
@kyliau kyliau deleted the parsed-property branch September 30, 2020 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ayazhafiz ayazhafiz ayazhafiz approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyliau @AndrewKushnir @ayazhafiz @googlebot