Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix bad pullapprove rule #36232

Closed
wants to merge 1 commit into from

Conversation

@josephperrott
Copy link
Member

josephperrott commented Mar 24, 2020

The dev-infra pull approve group contained a condition with
the glob having a string concatenation rather than a comma
separated list. This corrects this error, and in another PR
we will correct the verification scripts failure to catch
this.

@josephperrott josephperrott force-pushed the josephperrott:pullapprove-fix branch from 421b721 to a692aa1 Mar 24, 2020
The dev-infra pull approve group contained a condition with
the glob having a string concatenation rather than a comma
separated list. This corrects this error, and in another PR
we will correct the verification scripts failure to catch
this.
@josephperrott josephperrott force-pushed the josephperrott:pullapprove-fix branch from a692aa1 to 42709a8 Mar 24, 2020
Copy link
Member

devversion left a comment

👍 for updating the script to catch this. PullApprove should error too?

@josephperrott

This comment has been minimized.

Copy link
Member Author

josephperrott commented Mar 25, 2020

@devversion yes, this will be done in a followup.

@alxhub alxhub closed this in b54db86 Mar 27, 2020
alxhub added a commit that referenced this pull request Mar 27, 2020
The dev-infra pull approve group contained a condition with
the glob having a string concatenation rather than a comma
separated list. This corrects this error, and in another PR
we will correct the verification scripts failure to catch
this.

PR Close #36232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.