From 1c9985cf36682910913eb8f24943af87d73baac8 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Tue, 14 Apr 2020 13:17:43 -0700 Subject: [PATCH] build: fix circular deps failure With the large scale refactoring of the repo to the new version of clang-format, some import orders were changed. Specifically the imports found in this range. The file previously read: import {TestBed} from './test_bed'; import {ComponentFixtureAutoDetect, ComponentFixtureNoNgZone, TestBedStatic, TestComponentRenderer, TestModuleMetadata} from './test_bed_common'; import {R3TestBedCompiler} from './r3_test_bed_compiler'; and now reads: import {R3TestBedCompiler} from './r3_test_bed_compiler'; import {TestBed} from './test_bed'; import {ComponentFixtureAutoDetect, ComponentFixtureNoNgZone, TestBedStatic, TestComponentRenderer, TestModuleMetadata} from './test_bed_common'; This change in order cause the circular dependency to be entered earlier and changed the golden file for our circular deps discovery. --- goldens/packages-circular-deps.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/goldens/packages-circular-deps.json b/goldens/packages-circular-deps.json index aed337abef890..808af2db232c8 100644 --- a/goldens/packages-circular-deps.json +++ b/goldens/packages-circular-deps.json @@ -1807,9 +1807,10 @@ "packages/core/src/render3/interfaces/view.ts" ], [ - "packages/core/testing/src/r3_test_bed.ts", + "packages/core/testing/src/r3_test_bed_compiler.ts", "packages/core/testing/src/test_bed_common.ts", - "packages/core/testing/src/test_bed.ts" + "packages/core/testing/src/test_bed.ts", + "packages/core/testing/src/r3_test_bed.ts" ], [ "packages/core/testing/src/r3_test_bed.ts",