Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): do not return external template that does not exist #39898

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Dec 1, 2020

There is a bug in tsserver that causes it to crash when it tries to create
script info for an external template that does not exist.

I've submitted an upstream PR
microsoft/TypeScript#41737 to fix this, but before
the commit lands in the stable release, we'll have to workaround the issue
in language service.

Close angular/vscode-ng-language-service#1001

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added comp: language-service target: patch This PR is targeted for the next patch release labels Dec 1, 2020
@kyliau kyliau requested review from atscott and ayazhafiz Dec 1, 2020
@ngbot ngbot bot added this to the needsTriage milestone Dec 1, 2020
@google-cla google-cla bot added the cla: yes label Dec 1, 2020
@ayazhafiz
Copy link
Member

@ayazhafiz ayazhafiz commented Dec 1, 2020

LGTM, but I think the underlying issue that this PR addresses is more subtle than just a missing path, see angular/vscode-ng-language-service#1001 (comment).

…exist

There is a bug in tsserver that causes it to crash when it tries to create
script info for an external template that does not exist.

I've submitted an upstream PR
microsoft/TypeScript#41737 to fix this, but before
the commit lands in the stable release, we'll have to workaround the issue
in language service.

Close angular/vscode-ng-language-service#1001
@kyliau kyliau removed the request for review from atscott Dec 2, 2020
@kyliau kyliau added the action: merge PR author is ready for this to merge label Dec 2, 2020
mhevery pushed a commit that referenced this issue Dec 3, 2020
…exist (#39898)

There is a bug in tsserver that causes it to crash when it tries to create
script info for an external template that does not exist.

I've submitted an upstream PR
microsoft/TypeScript#41737 to fix this, but before
the commit lands in the stable release, we'll have to workaround the issue
in language service.

Close angular/vscode-ng-language-service#1001

PR Close #39898
@mhevery mhevery closed this in 2b84882 Dec 3, 2020
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Jan 3, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge PR author is ready for this to merge cla: yes comp: language-service target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants