Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animations): implement getPosition in browser animation builder #39983

Closed
wants to merge 1 commit into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Dec 5, 2020

Accidently closed #28264 re-opening it here.

Forward getPosition to animation_group_player.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

@google-cla google-cla bot commented Dec 5, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@cgatian
Copy link

@cgatian cgatian commented Dec 5, 2020

We have been waiting for this! This is the first contribution from the Hyland team. We are going celebrate when this is merged.

Good job @literalpie

@literalpie
Copy link
Contributor

@literalpie literalpie commented Dec 5, 2020

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 5, 2020
Forward `getPosition` to `animation_group_player`.
@mhevery
Copy link
Contributor Author

@mhevery mhevery commented Dec 7, 2020

presubmit

@literalpie
Copy link
Contributor

@literalpie literalpie commented Dec 8, 2020

I see that the presubmit check is failing. Is there anything I can do to help?

@mhevery mhevery added action: merge-assistance CARETAKER: please help get this green target: patch This PR is targeted for the next patch release labels Dec 8, 2020
@ngbot ngbot bot added the action: merge PR author is ready for this to merge label Dec 8, 2020
@mhevery
Copy link
Contributor Author

@mhevery mhevery commented Dec 8, 2020

MERGE_ASSISTANCE: This PR has already been approved in #28264 (and accidently closed) This will be merged without further approval.

@mhevery mhevery closed this in ca08625 Dec 9, 2020
mhevery pushed a commit that referenced this issue Dec 9, 2020
…39983)

Forward `getPosition` to `animation_group_player`.

PR Close #39983
@literalpie
Copy link
Contributor

@literalpie literalpie commented Dec 9, 2020

@mhevery was this unintentionally closed again?

@petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented Dec 9, 2020

@literalpie - no it was merged by our tooling which github doesn't understand, so we close the PR directly.

@literalpie
Copy link
Contributor

@literalpie literalpie commented Dec 9, 2020

Cool, thank you!

@JoostK
Copy link
Member

@JoostK JoostK commented Dec 9, 2020

As a matter of fact this has already been released in 11.0.4 :)

@JoostK JoostK linked an issue Dec 9, 2020 that may be closed by this pull request
@JoostK JoostK linked an issue Dec 9, 2020 that may be closed by this pull request
zarend pushed a commit to zarend/angular that referenced this issue Dec 10, 2020
twerske pushed a commit to twerske/angular that referenced this issue Jan 5, 2021
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Jan 9, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge PR author is ready for this to merge action: merge-assistance CARETAKER: please help get this green cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants