Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): Ensure ActivatedRouteSnapshot#title has correct value #47481

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Sep 19, 2022

ActivatedRouteSnapshot data gets mutated in the resolve phase of the Router. The title is assigned as part of this. As a result, the title must be a getter in order to pick up the value that was note available during the class creation.

fixes #47459

BREAKING CHANGE: The title property is now required on ActivatedRouteSnapshot

ActivatedRouteSnapshot data gets mutated in the resolve phase of the Router. The title is assigned as part of this.
As a result, the title must be a getter in order to pick up the value that was note available during the class creation.

fixes angular#47459

BREAKING CHANGE: The title property is now required on ActivatedRouteSnapshot
@atscott atscott added breaking changes target: major This PR is targeted for the next major release action: global presubmit A TGP is required and / or is running labels Sep 19, 2022
@atscott atscott added this to the v15 Feature Freeze milestone Sep 19, 2022
@ngbot ngbot bot removed this from the v15 Feature Freeze milestone Sep 19, 2022
@ngbot ngbot bot added this to the Backlog milestone Sep 19, 2022
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

reviewed-for: public-api

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Reviewed-for: public-api

@jessicajaniuk jessicajaniuk removed their request for review Sep 19, 2022
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

LGTM

Reviewed-for: public-api

@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 23, 2022

@atscott this PR got all the approvals but it seems like it needs a bit more work before it can land: g3 status is "failing" and I'm not sure if this is a flake or something that needs attention.

Also, since this is a breaking change, it should go to one of the v15 milestones, right?

@atscott
Copy link
Contributor Author

atscott commented Sep 23, 2022

@pkozlowski-opensource That's right. There is some remaining cleanup in g3 that is ongoing.

@atscott
Copy link
Contributor Author

atscott commented Sep 26, 2022

TGP with internal cleanups

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Sep 26, 2022
@alxhub
Copy link
Contributor

alxhub commented Sep 27, 2022

This PR was merged into the repository by commit 6a88bad.

@alxhub alxhub closed this in 6a88bad Sep 27, 2022
dylhunn pushed a commit to dylhunn/angular that referenced this pull request Sep 27, 2022
…ngular#47481)

ActivatedRouteSnapshot data gets mutated in the resolve phase of the Router. The title is assigned as part of this.
As a result, the title must be a getter in order to pick up the value that was note available during the class creation.

fixes angular#47459

BREAKING CHANGE: The title property is now required on ActivatedRouteSnapshot

PR Close angular#47481
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 28, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: global presubmit A TGP is required and / or is running action: merge The PR is ready for merge by the caretaker area: router breaking changes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@angular/router: ActivatedRoute.snapshot.title is always undefined
5 participants