refactor(compiler): use native BigInt when calculating i18n digests #48321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
target: minor
clydin
added
action: review
clydin
force-pushed
the
i18n/digest-bigint
branch
2 times, most recently
from
aeb4ea1
to
36c110d
Compare
To further modernize and improve the performance of the i18n digest generation, The 64-bit aspects of the process now use the native `BigInt` instead of a custom JavaScript implementation. This removes the need for the big_integer helper code and associated tests as the code was not used anywhere else in the framework. Only the `BigInt` constructor, `BigInt.asUintN` function, and `.toString` function are currently used. `BigInt` literals can unfortunately not yet be used due to the bazel test devmode setup which compiles the TypeScript code at an EcmaScript level that does not yet support the literals. Browser support information: - BigInt constructor: https://caniuse.com/mdn-javascript_builtins_bigint_bigint - BigInt asUintN: https://caniuse.com/mdn-javascript_builtins_bigint_asuintn - BigInt toString: https://caniuse.com/mdn-javascript_builtins_bigint_tostring
clydin
force-pushed
the
i18n/digest-bigint
branch
from
36c110d
to
c5ee382
Compare
JeanMeche
reviewed
Aug 1, 2023
AndrewKushnir
approved these changes
Sep 7, 2023
|
This PR was merged into the repository by commit 0f10d75. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ngular#48321) To further modernize and improve the performance of the i18n digest generation, The 64-bit aspects of the process now use the native `BigInt` instead of a custom JavaScript implementation. This removes the need for the big_integer helper code and associated tests as the code was not used anywhere else in the framework. Only the `BigInt` constructor, `BigInt.asUintN` function, and `.toString` function are currently used. `BigInt` literals can unfortunately not yet be used due to the bazel test devmode setup which compiles the TypeScript code at an EcmaScript level that does not yet support the literals. Browser support information: - BigInt constructor: https://caniuse.com/mdn-javascript_builtins_bigint_bigint - BigInt asUintN: https://caniuse.com/mdn-javascript_builtins_bigint_asuintn - BigInt toString: https://caniuse.com/mdn-javascript_builtins_bigint_tostring PR Close angular#48321
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
To further modernize and improve the performance of the i18n digest generation, The 64-bit aspects of the process now use the native
BigIntinstead of a custom JavaScript implementation. This removes the need for the big_integer helper code and associated tests as the code was not used anywhere else in the framework. Only theBigIntconstructor,BigInt.asUintNfunction, and.toStringfunction are currently used.BigIntliterals can unfortunately not yet be used due to the bazel test devmode setup which compiles the TypeScript code at an EcmaScript level that does not yet support the literals.This change plus the recent DataView refactoring results in a ~15% performance improvement for digest calculation.
Browser support information (
@angular/compilershould only be present in an application if using JIT mode):Node.js 10.4.0 and higher also provide support (Angular officially supports
^14.20.0 || ^16.13.0 || ^18.10.0).Does this PR introduce a breaking change?
Other information