Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPattern validator #5561
Closed
Pattern validator #5561
Conversation
|
@vsavkin can you chime in on what's going on here? |
|
@awiseman you can update the public api spec |
|
ok, should be all set. |
mary-poppins
commented
Feb 25, 2016
|
Merging PR #5561 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5561. |
akirasosa
added a commit
to springboot-angular2-tutorial/angular2-app
that referenced
this pull request
Mar 4, 2016
ruchirsachdeva
pushed a commit
to ruchirsachdeva/angular-web-client
that referenced
this pull request
Feb 19, 2017
angular-automatic-lock-bot
bot
commented
Sep 8, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
awiseman commentedDec 2, 2015
For #5411
Currently one unit test is failing: public_api_spec.ts
The comment said to not modify without permission, so I left it alone.