New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): separate ngModelGroup from formGroupName #9167

Merged
merged 1 commit into from Jun 13, 2016

Conversation

Projects
None yet
3 participants
@kara
Contributor

kara commented Jun 12, 2016

This PR separates ngControlGroup into two directives: ngModelGroup (template-driven) and formGroupName (reactive forms).

It is part of a larger API update described below:
https://docs.google.com/document/u/1/d/1RIezQqE4aEhBRmArIAS1mRIZtWFf6JxN_7B4meyWK0Y/pub

As this change only applies to the new forms folder (which is not the one linked in our main file, index.ts), there are no breaking changes.

@Host() @SkipSelf() parent: ControlContainer,
@Optional() @Self() @Inject(NG_VALIDATORS) validators: any[],
@Optional() @Self() @Inject(NG_ASYNC_VALIDATORS) asyncValidators: any[]) {
super();

This comment has been minimized.

@vsavkin

vsavkin Jun 13, 2016

Contributor

Why aren't you passing parent, validators, and asyncValidators to super()?

This comment has been minimized.

@kara

kara Jun 13, 2016

Contributor

None of the superclasses do anything with validators. They are simply saved on the subclass.

@kara kara merged commit 5c0cfde into angular:master Jun 13, 2016

2 of 4 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kara kara deleted the kara:ngControlGroup branch Jun 27, 2016

@kara kara added the comp: forms label Sep 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment