Skip to content
This repository has been archived by the owner on Feb 9, 2020. It is now read-only.

Hide.js console.logs should be opt-in #179

Closed
sangel10 opened this issue Dec 10, 2014 · 9 comments
Closed

Hide.js console.logs should be opt-in #179

sangel10 opened this issue Dec 10, 2014 · 9 comments

Comments

@sangel10
Copy link

I had to uninstall the extension as I was getting too many logs while at work, also most of the logs were coming from my vendor directory for modules that I was not responsible for. Just a heads up that maybe these should be opt-in.

@bengarvey
Copy link

Agreed. I went into panic mode this morning with all that console output plus other issues with our app until I realized it was due to the extension update. I had to disable batarang for now.

@nkpz
Copy link

nkpz commented Dec 10, 2014

I assume you mean hint.js - I was also startled by the sudden changes. I would be in favor of it being opt-out, but now that I know where it's coming from I don't mind. I often hear complaints about how hard it is to figure out what the best practices are when building an Angular project, and I think this addresses it, but it is disruptive when it starts happening out of nowhere.

edit: I just thought I had some major performance issues in my app, then profiled it to find that Batarang was spending around 1000ms spitting out hints. That's a problem. Again, very much in favor of the idea but it's off to a rocky start unfortunately

@jrthib
Copy link

jrthib commented Dec 10, 2014

I had to disable as well. Our app wouldn't run after the update, though the logs seem useful.

@c0bra
Copy link

c0bra commented Dec 10, 2014

Dittos. Had to disable because hint.js started throwing exceptions. Seems like there's a check for whether controller names are camel-cased or not and the argument it was receiving was an object and not a string.

@darwayne
Copy link

+1 it breaks my angular apps

@mg1075
Copy link

mg1075 commented Dec 10, 2014

+1 Batarang just broke my app.

@Splaktar
Copy link
Member

Duplicate of #158 and #159

You can find steps to rollback to a working version temporarily here: http://stackoverflow.com/a/27404493/633107

@the-simian
Copy link

FYI, The rest of batarang seems to be broken as well for me.

@btford
Copy link
Contributor

btford commented Dec 10, 2014

Console messages removed via angular/angular-hint@160b15b

These changes are in a v0.6.1 release that I just pushed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants