Skip to content

fix(material-experimental/mdc-chips): chip set not picking up indirect descendant chips #17568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 1, 2019

Fixes the MDC-based chip set not picking up indirect descendant chips.

…t descendant chips

Fixes the MDC-based chip set not picking up indirect descendant chips.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Nov 1, 2019
@crisbeto crisbeto added this to the 9.0.0 milestone Nov 1, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner November 1, 2019 13:57
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 1, 2019
@mmalerba
Copy link
Contributor

mmalerba commented Nov 1, 2019

mdc-chips is actually in use by a team internally, so marking as not merge-safe

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 1, 2019
@mmalerba mmalerba merged commit e7aeee4 into angular:master Nov 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants