Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatDialog breaks JIT compilation in ivy angular@9.0.0-rc.0 #17644

Closed
naturalfreak opened this issue Nov 7, 2019 · 5 comments
Assignees

Comments

@naturalfreak
Copy link

@naturalfreak naturalfreak commented Nov 7, 2019

JIT compilation breaks when change something in dialog component.

Reproduction files

Reproduction instructions:
npm install
npm run start
enter in ~/src/app/dialog/component.ts and change something, after compilation you will receive error in browser.

Node - v12.13.0
npm - 6.12.0
OS - Ubuntu 16.04
angular - 9.0.0-rc.0
material - 9.0.0-rc.0

Can't bind to 'ngForOf' since it isn't a known property of 'p'.
| warnAboutUnknownProperty | @ | core.js:14269
-- | -- | -- | --
| elementPropertyInternal | @ | core.js:14151
| ɵɵproperty | @ | core.js:23930
| AppComponent_Template | @ | app.component.html:1
| executeTemplate | @ | core.js:13684
| refreshView | @ | core.js:13543
| refreshComponent | @ | core.js:14828
| refreshChildComponents | @ | core.js:13280
| refreshView | @ | core.js:13597
| renderComponentOrTemplate | @ | core.js:13658
| tickRootContext | @ | core.js:14992
| detectChangesInRootView | @ | core.js:15027
| detectChanges | @ | core.js:16555
| tick | @ | core.js:42409
| _loadComponent | @ | core.js:42460
| bootstrap | @ | core.js:42383
| (anonymous) | @ | core.js:41978
| _moduleDoBootstrap | @ | core.js:41974
| (anonymous) | @ | core.js:41929
| invoke | @ | zone-evergreen.js:365
| onInvoke | @ | core.js:40986
| invoke | @ | zone-evergreen.js:364
| run | @ | zone-evergreen.js:124
| (anonymous) | @ | zone-evergreen.js:851
| invokeTask | @ | zone-evergreen.js:400
| onInvokeTask | @ | core.js:40964
| invokeTask | @ | zone-evergreen.js:399
| runTask | @ | zone-evergreen.js:168
| drainMicroTaskQueue | @ | zone-evergreen.js:570
| Promise.then (async) | |
| scheduleMicroTask | @ | zone-evergreen.js:553
| scheduleTask | @ | zone-evergreen.js:389
| scheduleTask | @ | zone-evergreen.js:211
| scheduleMicroTask | @ | zone-evergreen.js:231
| scheduleResolveOrReject | @ | zone-evergreen.js:841
| then | @ | zone-evergreen.js:967
| bootstrapModule | @ | core.js:41959
| ./src/main.ts | @ | main.ts:11
| webpack_require | @ | bootstrap:79
| 0 | @ | main.ts:12
| webpack_require | @ | bootstrap:79
| checkDeferredModules | @ | bootstrap:45
| webpackJsonpCallback | @ | bootstrap:32
| (anonymous) | @ | main.js:1

@naturalfreak naturalfreak changed the title MatDialog breaks JIT compilation in angular@9.0.0-rc.0 MatDialog breaks JIT compilation in ivy angular@9.0.0-rc.0 Nov 7, 2019
@Splaktar Splaktar self-assigned this Nov 14, 2019
@Splaktar

This comment has been minimized.

Copy link
Member

@Splaktar Splaktar commented Nov 14, 2019

I'm not able to reproduce this with the repo provided in the ZIP file. I've pushed the changes from the ZIP file plus some minor clean up to https://github.com/Splaktar/mat-dialog-ivy-17644. It looks like this was either fixed by a few minor changes (see my commit) or the latest RC versions.

I'm going to close this, but please feel free to open a PR to the above repo to help provide a reproduction if this is still and issue. Then I will reopen this issue if we can identify a bug.

@naturalfreak

This comment has been minimized.

Copy link
Author

@naturalfreak naturalfreak commented Nov 15, 2019

With repo above. And with a bigger project it gets worse
bug

@Splaktar

This comment has been minimized.

Copy link
Member

@Splaktar Splaktar commented Nov 15, 2019

So you have to make a change to the source code while ng serve is running in order to see the error?

@naturalfreak

This comment has been minimized.

Copy link
Author

@naturalfreak naturalfreak commented Nov 15, 2019

Yes, you should change something in dialog component. If you change something in another component which is not dialog everything is fine. But when you change in dialog component you should stop ng serve and start it again to work normal.

@Splaktar

This comment has been minimized.

Copy link
Member

@Splaktar Splaktar commented Nov 15, 2019

That looks and sounds a lot like these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.