fix(clipboard): leak if directive is destroyed while a copy is pending #18066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 10, 2020
If the `cdkCopyToClipboard` directive is destroyed while there are pending copies, we'll create a leak since the `PendingCopy` will never be destroyed. These changes add some extra logic to ensure that the copies are destroyed and the timeouts are cleared.
crisbeto
force-pushed
the
copy-destroy-leak
branch
from
b35909c
to
1401729
Compare
|
I've addressed the feedback and rebased @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
angular#18066) If the `cdkCopyToClipboard` directive is destroyed while there are pending copies, we'll create a leak since the `PendingCopy` will never be destroyed. These changes add some extra logic to ensure that the copies are destroyed and the timeouts are cleared.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
cdkCopyToClipboarddirective is destroyed while there are pending copies, we'll create a leak since thePendingCopywill never be destroyed. These changes add some extra logic to ensure that the copies are destroyed and the timeouts are cleared.