Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update to MDC 4.0.0 stable #17633

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@crisbeto
Copy link
Member

crisbeto commented Nov 6, 2019

Updates the repo to MDC 4.0.0 stable and fixes the breaking changes.

@crisbeto crisbeto added this to the 9.0.0 milestone Nov 6, 2019
@crisbeto crisbeto requested review from andrewseguin, jelbourn and angular/dev-infra-components as code owners Nov 6, 2019
@googlebot googlebot added the cla: yes label Nov 6, 2019
@crisbeto crisbeto force-pushed the crisbeto:mdc-4.0.0-stable branch 2 times, most recently from 3e88ac2 to 3d830de Nov 6, 2019
@mmalerba

This comment has been minimized.

Copy link
Contributor

mmalerba commented Nov 7, 2019

looks like there's one failing test for progress bar

Updates the repo to MDC 4.0.0 stable and fixes the breaking changes.
@crisbeto crisbeto force-pushed the crisbeto:mdc-4.0.0-stable branch from 3d830de to 6463e14 Nov 7, 2019
@crisbeto

This comment has been minimized.

Copy link
Member Author

crisbeto commented Nov 7, 2019

The tests should be sorted out now.

Copy link
Member

devversion left a comment

💯 This should finally make master green!

Copy link
Member

josephperrott left a comment

LGTM

@mmalerba mmalerba merged commit 466903e into angular:master Nov 7, 2019
11 checks passed
11 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.