Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips): handle ripple color in theme using CSS variables #17649

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@crisbeto
Copy link
Member

crisbeto commented Nov 8, 2019

The ripple color for selected chips is set through rgba which won't work properly if the theme uses CSS variables. These changes add a fallback.

Copy link
Member

jelbourn left a comment

LGTM

The ripple color for selected chips is set through `rgba` which won't work properly if the theme uses CSS variables. These changes add a fallback.
@crisbeto crisbeto force-pushed the crisbeto:chips-ripple-color-css-variable branch from d30f1ce to dde0310 Nov 8, 2019
@mmalerba mmalerba merged commit 1923f7f into angular:master Nov 11, 2019
11 checks passed
11 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.