Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch mdc snapshot test to run against master branch #17652

Conversation

@devversion
Copy link
Member

devversion commented Nov 8, 2019

We currently run the MDC snapshot tests against their develop
branch. This breaks at the moment since MDC deleted the branch
in order to release a new major version.

It's unclear what Git process they use, but considering they use
Gitflow, then the develop branch should have not been deleted. This
would be ideal for us.. because then we can just always run against
develop.

For now though, since the branch does not exist anymore, we should
switch to master so that the CI job can be green.

We currently run the MDC snapshot tests against their `develop`
branch. This breaks at the moment since MDC deleted the branch
in order to release a new major version.

It's unclear what Git process they use, but considering they use
Gitflow, then the `develop` branch should have not been deleted. This
would be ideal for us.. because then we can just _always_ run against
`develop`.

For now though, since the branch does not exist anymore, we should
switch to master so that the CI job can be green.
@devversion devversion requested a review from angular/dev-infra-components as a code owner Nov 8, 2019
@googlebot googlebot added the cla: yes label Nov 8, 2019
Copy link
Member

josephperrott left a comment

LGTM

@josephperrott josephperrott merged commit b8b0f57 into angular:master Nov 8, 2019
11 checks passed
11 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.