Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk/testing): support querying for multiple TestHarness / Compon… #17658

Merged
merged 6 commits into from Nov 19, 2019

Conversation

@mmalerba
Copy link
Contributor

mmalerba commented Nov 9, 2019

…entHarness at once in locatorFor

This feature is needed for the MatListHarness, so we can query for a combined list of list items, headers, and dividers, while maintaining the DOM order. The new API is a super-set of the old one, so non-breaking.

@googlebot googlebot added the cla: yes label Nov 9, 2019
@mmalerba mmalerba force-pushed the mmalerba:locator-for branch from f85fc5a to c5f4af1 Nov 9, 2019
@mmalerba mmalerba requested a review from angular/dev-infra-components as a code owner Nov 9, 2019
src/cdk/testing/component-harness.ts Outdated Show resolved Hide resolved
src/cdk/testing/component-harness.ts Outdated Show resolved Hide resolved
src/cdk/testing/component-harness.ts Outdated Show resolved Hide resolved
src/cdk/testing/component-harness.ts Show resolved Hide resolved
src/cdk/testing/component-harness.ts Show resolved Hide resolved
src/cdk/testing/component-harness.ts Outdated Show resolved Hide resolved
src/cdk/testing/harness-environment.ts Outdated Show resolved Hide resolved
src/cdk/testing/harness-environment.ts Outdated Show resolved Hide resolved
src/cdk/testing/harness-environment.ts Outdated Show resolved Hide resolved
src/cdk/testing/harness-environment.ts Outdated Show resolved Hide resolved
@mmalerba mmalerba force-pushed the mmalerba:locator-for branch from 6c3c040 to 759893e Nov 12, 2019
Copy link
Member

devversion left a comment

LGTM

src/cdk/testing/harness-environment.ts Show resolved Hide resolved
src/cdk/testing/harness-environment.ts Outdated Show resolved Hide resolved
mmalerba added 4 commits Nov 9, 2019
…entHarness at once in locatorFor
@mmalerba mmalerba force-pushed the mmalerba:locator-for branch from 759893e to 28a6497 Nov 12, 2019
Copy link
Member

devversion left a comment

LGTM. As a minor nit: It would be nice to mention that the skipSelectorCheck is only for performance purposes IMO.

@devversion devversion added the pr: lgtm label Nov 12, 2019
Copy link
Member

jelbourn left a comment

LGTM, one small comment

src/cdk/testing/component-harness.ts Outdated Show resolved Hide resolved
@jelbourn

This comment has been minimized.

Copy link
Member

jelbourn commented Nov 18, 2019

@mmalerba should this target 9.1?

@mmalerba mmalerba added this to the 9.0.0 milestone Nov 19, 2019
@mmalerba mmalerba added the P2 label Nov 19, 2019
@mmalerba

This comment has been minimized.

Copy link
Contributor Author

mmalerba commented Nov 19, 2019

I think we should try to get it in 9.0

@mmalerba mmalerba merged commit 15a5171 into angular:master Nov 19, 2019
11 checks passed
11 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@mmalerba mmalerba deleted the mmalerba:locator-for branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.