Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(youtube-player): clean up internal observables #17835

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@crisbeto
Copy link
Member

crisbeto commented Nov 28, 2019

Switches the internal observables of the youtube-player to be Subject so they're consistent with the rest of the repo and ensures that they're completed on destroy.

Switches the internal observables of the `youtube-player` to be `Subject` so they're consistent with the rest of the repo and ensures that they're completed on destroy.
Copy link
Member

jelbourn left a comment

LGTM

@jelbourn jelbourn merged commit ab0f30d into angular:master Nov 28, 2019
11 checks passed
11 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.