Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disallow usages of the first operator #17836

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@crisbeto
Copy link
Member

crisbeto commented Nov 28, 2019

The first operator will throw if the observable completes before it has emitted. A long time ago we went through and updated all the usages to take(1), but recently a couple of new usages were introduced so we might as well lint for it so it doesn't happen again.

The `first` operator will throw if the observable completes before it has emitted. A long time ago we went through and updated all the usages to `take(1)`, but recently a couple of new usages were introduced so we might as well lint for it so it doesn't happen again.
@crisbeto crisbeto requested review from jelbourn and angular/dev-infra-components as code owners Nov 28, 2019
@googlebot googlebot added the cla: yes label Nov 28, 2019
Copy link
Member

jelbourn left a comment

LGTM

@jelbourn jelbourn merged commit d4a2a0c into angular:master Nov 28, 2019
11 checks passed
11 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.