Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: disallow usages of the first operator #17836
Merged
+1
−0
Conversation
The `first` operator will throw if the observable completes before it has emitted. A long time ago we went through and updated all the usages to `take(1)`, but recently a couple of new usages were introduced so we might as well lint for it so it doesn't happen again.
crisbeto
requested review from
jelbourn and
angular/dev-infra-components
as
code owners
|
LGTM |
jelbourn
merged commit d4a2a0c
into
angular:master
11 checks passed
11 checks passed
ci/angular: merge status
All checks passed!
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
crisbeto commentedNov 28, 2019
The
firstoperator will throw if the observable completes before it has emitted. A long time ago we went through and updated all the usages totake(1), but recently a couple of new usages were introduced so we might as well lint for it so it doesn't happen again.