Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updocs(tree): injectable decorator set on wrong class #17843
Conversation
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
Just needs rebase |
This comment has been minimized.
This comment has been minimized.
|
Rebased. |
jelbourn
merged commit 2d407a2
into
angular:master
10 of 11 checks passed
10 of 11 checks passed
ci/angular: merge status
Missing required labels: target: *
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
crisbeto commentedNov 29, 2019
Fixes the
Injectabledecorator being set on the wrong class in one of the tree examples. This hasn't broken until now because that class isn't using DI anyway.Fixes #17815.