Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tree): injectable decorator set on wrong class #17843

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@crisbeto
Copy link
Member

crisbeto commented Nov 29, 2019

Fixes the Injectable decorator being set on the wrong class in one of the tree examples. This hasn't broken until now because that class isn't using DI anyway.

Fixes #17815.

Copy link
Member

jelbourn left a comment

LGTM

@jelbourn

This comment has been minimized.

Copy link
Member

jelbourn commented Dec 2, 2019

Just needs rebase

Fixes the `Injectable` decorator being set on the wrong class in one of the tree examples. This hasn't broken until now because that class isn't using DI anyway.

Fixes #17815.
@crisbeto crisbeto force-pushed the crisbeto:tree-wrong-injectable branch from e00ec4d to 919f070 Dec 2, 2019
@crisbeto

This comment has been minimized.

Copy link
Member Author

crisbeto commented Dec 2, 2019

Rebased.

@jelbourn jelbourn merged commit 2d407a2 into angular:master Dec 2, 2019
10 of 11 checks passed
10 of 11 checks passed
ci/angular: merge status Missing required labels: target: *
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.