Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/*) Focus indicator unit tests #18150

Merged
merged 8 commits into from Jan 13, 2020

Conversation

@zelliott
Copy link
Collaborator

zelliott commented Jan 10, 2020

  • Added basic unit tests to every component that ensures that the class .mat-focus-indicator exists on the appropriate element.
  • Removed overflow: hidden from .mat-tree-node in MatTree (as it was cutting off some of the focus indicator).
@googlebot googlebot added the cla: yes label Jan 10, 2020
@zelliott zelliott force-pushed the zelliott:focus-indicator branch from 5606217 to 992f7ee Jan 10, 2020
@zelliott zelliott changed the title Focus indicator tests & minor rendering improvements. Focus indicator unit tests Jan 10, 2020
@zelliott zelliott changed the title Focus indicator unit tests feat(material/*) Focus indicator unit tests Jan 10, 2020
@zelliott zelliott requested review from jelbourn and mmalerba Jan 10, 2020
@zelliott zelliott marked this pull request as ready for review Jan 10, 2020
@zelliott zelliott removed the request for review from andrewseguin Jan 10, 2020
@@ -9,7 +9,6 @@ $mat-node-height: 48px;
align-items: center;
min-height: $mat-node-height;
flex: 1;
overflow: hidden;

This comment has been minimized.

Copy link
@jelbourn

jelbourn Jan 11, 2020

Member

It would be good to see if this changes any screenshots in Google by running a global presubmit with just this line changed

This comment has been minimized.

Copy link
@zelliott

zelliott Jan 11, 2020

Author Collaborator

Changed 2 screenshots, but one was an improvement in my opinion and the other was a very nit box-shadow diff of some kind. Nothing major.

@zelliott zelliott requested a review from jelbourn Jan 13, 2020
Copy link
Member

jelbourn left a comment

LGTM

@jelbourn jelbourn merged commit f724e4d into angular:focus-indicator Jan 13, 2020
11 of 12 checks passed
11 of 12 checks passed
ci/angular: merge status Missing required labels: target: *
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
zelliott added a commit to zelliott/components that referenced this pull request Jan 14, 2020
…the ripple target

_document should be an optional param to avoid breaking change.

Added unit tests for focus indicator, improved focus indicator color on particular components.

Some minor style changes.

Cleaned up focus indicator unit tests.

Some more minor unit test formatting changes, undo coloring changes for now.

Fixed formatting.

Fixed final linter error.

feat(material/*) Focus indicator unit tests (angular#18150)

* Add focus indicators to mat-chip. Use a dynamically added element as the ripple target

* _document should be an optional param to avoid breaking change.

* Added unit tests for focus indicator, improved focus indicator color on particular components.

* Some minor style changes.

* Cleaned up focus indicator unit tests.

* Some more minor unit test formatting changes, undo coloring changes for now.

* Fixed formatting.

* Fixed final linter error.

feat(material-experimental/*): add focus indicators
zelliott added a commit to zelliott/components that referenced this pull request Jan 21, 2020
* Add focus indicators to mat-chip. Use a dynamically added element as the ripple target

* _document should be an optional param to avoid breaking change.

* Added unit tests for focus indicator, improved focus indicator color on particular components.

* Some minor style changes.

* Cleaned up focus indicator unit tests.

* Some more minor unit test formatting changes, undo coloring changes for now.

* Fixed formatting.

* Fixed final linter error.
mmalerba added a commit that referenced this pull request Jan 21, 2020
* Add focus indicators to mat-chip. Use a dynamically added element as the ripple target

* _document should be an optional param to avoid breaking change.

* Added unit tests for focus indicator, improved focus indicator color on particular components.

* Some minor style changes.

* Cleaned up focus indicator unit tests.

* Some more minor unit test formatting changes, undo coloring changes for now.

* Fixed formatting.

* Fixed final linter error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.