Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cdk): correct code sample for test harnesses #18153

Conversation

@LayZeeDK
Copy link
Contributor

LayZeeDK commented Jan 11, 2020

We want to resolve multiple menu items so we need ComponentHarness#locatorForAll(HarnessPredicate).

@LayZeeDK LayZeeDK requested review from devversion and mmalerba as code owners Jan 11, 2020
@googlebot googlebot added the cla: yes label Jan 11, 2020
@mmalerba mmalerba merged commit 5df0916 into angular:master Jan 11, 2020
11 of 12 checks passed
11 of 12 checks passed
ci/angular: merge status Missing required labels: target: *
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@LayZeeDK LayZeeDK deleted the LayZeeDK:LayZeeDK/docs/correct-test-harenesses-code-sample branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.