Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make cross entrypoint rule an AbstractRule #18156

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@crisbeto
Copy link
Member

crisbeto commented Jan 12, 2020

Currently the cross entrypoint import rule is a TypedRule which means that it might use the type checker and it won't work in vscode. Since it doesn't actually use the type checker, these changes turn it into an AbstractRule.

Currently the cross entrypoint import rule us a `TypedRule` which means that it might use the type checker and it won't work in vscode. Since it doesn't actually use the type checker, these changes turn it into an `AbstractRule`.
@crisbeto crisbeto requested a review from angular/dev-infra-components as a code owner Jan 12, 2020
@googlebot googlebot added the cla: yes label Jan 12, 2020
Copy link
Member

jelbourn left a comment

LGTM

Off-topic: I always find seeing lint rules in my IDE to be more annoying than helpful because they always show up while I'm in the middle of writing. It's like, "Yeah, I know it's an unused variable, I just made it, give me a minute".

@andrewseguin andrewseguin merged commit 1d9033e into angular:master Jan 15, 2020
12 checks passed
12 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.