Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove custom rxjs imports rule in favor of import-banlist rule #18157

Merged

Conversation

@devversion
Copy link
Member

devversion commented Jan 12, 2020

No description provided.

@devversion devversion requested review from jelbourn and angular/dev-infra-components as code owners Jan 12, 2020
@googlebot googlebot added the cla: yes label Jan 12, 2020
Copy link
Member

crisbeto left a comment

LGTM

Copy link
Member

jelbourn left a comment

LGTM, looks like it needs a rebase now

@devversion devversion force-pushed the devversion:build/remove-custom-rxjs-import-rule branch from 0abc189 to fc698f3 Jan 16, 2020
@devversion

This comment has been minimized.

Copy link
Member Author

devversion commented Jan 16, 2020

Rebased.

@jelbourn jelbourn merged commit 581d1f2 into angular:master Jan 16, 2020
12 checks passed
12 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.