Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material-experimental/mdc-form-field): add test harness #18165

Merged
merged 1 commit into from Jan 22, 2020

Conversation

@devversion
Copy link
Member

devversion commented Jan 13, 2020

Adds a new test harness for the MDC-based form-field.

@devversion devversion requested review from jelbourn, mmalerba and angular/dev-infra-components as code owners Jan 13, 2020
@googlebot googlebot added the cla: yes label Jan 13, 2020
providers: [MAT_SELECT_SCROLL_STRATEGY_PROVIDER]
})
export class SelectWithoutFormFieldModule {
}

This comment has been minimized.

Copy link
@devversion

devversion Jan 13, 2020

Author Member

I'm not sure about this. It seem reasonable for now, but long-term that might be just the MDC based select module

async hasFloatingLabel(): Promise<boolean> {
return (await this.host()).hasClass('mat-form-field-can-float');
}

This comment has been minimized.

Copy link
@devversion

devversion Jan 13, 2020

Author Member

I'm proposing that we remove this method. It will only make sense in the non-MDC based form-field where floatLabel = never in the legacy appearance is supported. Not even adding it as part of the first stable release, will avoid a breaking change.

This comment has been minimized.

Copy link
@jelbourn

jelbourn Jan 13, 2020

Member

It's not used in Google presently

@devversion devversion force-pushed the devversion:feat/mdc-form-field-harness branch from 99b1f57 to d0ad251 Jan 13, 2020
Copy link
Member

jelbourn left a comment

LGTM

async hasFloatingLabel(): Promise<boolean> {
return (await this.host()).hasClass('mat-form-field-can-float');
}

This comment has been minimized.

Copy link
@jelbourn

jelbourn Jan 13, 2020

Member

It's not used in Google presently

@devversion devversion force-pushed the devversion:feat/mdc-form-field-harness branch from d0ad251 to 58993ef Jan 22, 2020
@jelbourn jelbourn merged commit 944837f into angular:master Jan 22, 2020
12 checks passed
12 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.