Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(material/bottom-sheet) clarify closeOnNavigation defaults to true #18909

Open
wants to merge 1 commit into
base: master
from

Conversation

@davidjgoss
Copy link

davidjgoss commented Mar 25, 2020

No description provided.

@davidjgoss davidjgoss requested review from crisbeto and jelbourn as code owners Mar 25, 2020
@googlebot googlebot added the cla: yes label Mar 25, 2020
@@ -44,7 +44,7 @@ export class MatBottomSheetConfig<D = any> {
/**
* Whether the bottom sheet should close when the user goes backwards/forwards in history.
* Note that this usually doesn't include clicking on links (unless the user is using
* the `HashLocationStrategy`).
* the `HashLocationStrategy`). Defaults to `true`.

This comment has been minimized.

Copy link
@crisbeto

crisbeto Mar 25, 2020

Member

We intentionally try to avoid specifying defaults in the docs, because they tend to get out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.