Skip to content

Conversation

@Jordan-Hall
Copy link

Add rail support for the drawer.

Added a new mode for drawer rail mode="rail" inline with https://material.io/components/navigation-rail

This PR will resolve #1728 #1728

Signed-off-by: Jordan Hall <libertyware@MacBook-Pro.local>
@Jordan-Hall Jordan-Hall requested a review from mmalerba as a code owner July 20, 2020 23:25
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jul 20, 2020
@Jordan-Hall
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mmalerba
Copy link
Contributor

This needs further design discussion between the Angular Components and MDC teams before we can proceed. The spec seems to consider the navigation drawer and navigation rail to be different components. It may make sense to combine them, but I don't think this is something we can say for sure without further discussion.

@mmalerba mmalerba added blocked This issue is blocked by some external factor, such as a prerequisite PR material spec Issue related to the Material Design spec https://material.io/design/ labels Jul 30, 2020
@Jordan-Hall
Copy link
Author

@mmalerba the specs state its different, however then it goes onto say it can be used as a drawer. Angular Material still need a different component for rail itself. But it doesn't make sense to add the drawer functionality into rail itself

@Char2sGu
Copy link

Useful features are always deposited

@Jordan-Hall
Copy link
Author

@googlebot I fixed it

@josephperrott josephperrott deleted the branch angular:master April 28, 2022 17:43
@devversion
Copy link
Member

Hey, please re-open the pull request if still valid. The PR got auto-closed by GitHub when we renamed our primary branch.

@Jordan-Hall
Copy link
Author

Hey, please re-open the pull request if still valid. The PR got auto-closed by GitHub when we renamed our primary branch.

Depends if you want it. Still have it updated on a separate package. But last thing I heard, you was waiting on specs from material design.

@devversion
Copy link
Member

I can't unfortunately give you a better response/update here since I haven't been involved in potential discussions here with the Material Design team. It's great to hear that you are maintaining this effort as a separate project though.

I would need to defer for updates/feedback on this to @mmalerba.

@mmalerba
Copy link
Contributor

mmalerba commented May 3, 2022

The spec for the drawer/sidenav has changed pretty significantly from when this components was authored. I think we still want to rethink the API as a whole rather than adding a rail mode to the current API, but thank you for maintaining it separately for those who need it now.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

blocked This issue is blocked by some external factor, such as a prerequisite PR cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla material spec Issue related to the Material Design spec https://material.io/design/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navigation drawer - Mini variant behavior

6 participants