-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(drawer): add rail drawer support #20050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jordan Hall <libertyware@MacBook-Pro.local>
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
This needs further design discussion between the Angular Components and MDC teams before we can proceed. The spec seems to consider the navigation drawer and navigation rail to be different components. It may make sense to combine them, but I don't think this is something we can say for sure without further discussion. |
|
@mmalerba the specs state its different, however then it goes onto say it can be used as a drawer. Angular Material still need a different component for rail itself. But it doesn't make sense to add the drawer functionality into rail itself |
|
Useful features are always deposited |
|
@googlebot I fixed it |
|
Hey, please re-open the pull request if still valid. The PR got auto-closed by GitHub when we renamed our primary branch. |
Depends if you want it. Still have it updated on a separate package. But last thing I heard, you was waiting on specs from material design. |
|
I can't unfortunately give you a better response/update here since I haven't been involved in potential discussions here with the Material Design team. It's great to hear that you are maintaining this effort as a separate project though. I would need to defer for updates/feedback on this to @mmalerba. |
|
The spec for the drawer/sidenav has changed pretty significantly from when this components was authored. I think we still want to rethink the API as a whole rather than adding a rail mode to the current API, but thank you for maintaining it separately for those who need it now. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add rail support for the drawer.
Added a new mode for drawer rail
mode="rail"inline with https://material.io/components/navigation-railThis PR will resolve #1728 #1728