build: fix wrong SASS path #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: no
Fixes SASS errors when Material is imported directly. Fixes angular#2133.
crisbeto
force-pushed
the
2133/sass-path-fail
branch
from
6aac086 to
b701e4d
Compare
googlebot
added
cla: yes
|
LGTM I'd like to figure out why this didn't cause a problem: our build worked, sample apps worked, and all of the internal Google sass builds using Material worked. Is it possibly something that is only an error in older versions of sass? Is it a ruby vs. libsass thing? |
|
No idea, I can spend some more time with it over the weekend. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SASS errors when Material is imported directly.
Fixes #2133.