Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tooltip): animations running when timeouts haven't elapsed #25701

Merged
merged 1 commit into from Sep 26, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 26, 2022

This is a patch-only port of #25699.

After the tooltips were switched to CSS animations, a regression was introduced where the opposite animation is shown even if the tooltip didn't actually reach its target state.

These changes are an alternate take on the fix from #24652 which had to be reverted due to internal failures.

Fixes #24614.

…ed (angular#25699)

After the tooltips were switched to CSS animations, a regression was introduced where the opposite animation is shown even if the tooltip didn't actually reach its target state.

These changes are an alternate take on the fix from angular#24652 which had to be reverted due to internal failures.

Fixes angular#24614.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe This PR does not affect library code used inside Google and can be merged without a Google presubmit target: patch This PR is targeted for the next patch release labels Sep 26, 2022
@crisbeto crisbeto requested a review from devversion Sep 26, 2022
@crisbeto crisbeto requested a review from andrewseguin as a code owner Sep 26, 2022
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 26, 2022
@crisbeto crisbeto merged commit a9d3bc5 into angular:14.2.x Sep 26, 2022
18 of 21 checks passed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Oct 5, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.2.2/14.2.3) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.2.2/14.2.3) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.2.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1423-wool-wombat-2022-09-28)

[Compare Source](angular/components@14.2.2...14.2.3)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [8c3d79156](angular/components@8c3d791) | fix | **bottom-sheet:** aria-modal not being set |
| [7d314a87b](angular/components@7d314a8) | fix | **dialog:** aria-modal not being set |
| [bc978445b](angular/components@bc97844) | fix | **stepper:** remove invalid aria attribute ([#&#8203;25644](angular/components#25644)) |
| [a9d3bc580](angular/components@a9d3bc5) | fix | **tooltip:** animations running when timeouts haven't elapsed ([#&#8203;25699](angular/components#25699)) ([#&#8203;25701](angular/components#25701)) |

#### Special Thanks

James Skinner, Kristiyan Kostadinov and Paul Gschwendtner

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMCIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1568
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 27, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker merge safe This PR does not affect library code used inside Google and can be merged without a Google presubmit P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants